Repository navigation
fix(cli): print null when get attr misses - #2522
Open
MaxWang007 wants to merge 1 commit into
Open
MaxWang007 wants to merge 1 commit into
MaxWang007 wants to merge 1 commit into
Conversation
A missing attribute came back as JSON null. Plain text only printed string values, so the formatter fell through to the generic success line and a read looked like click or fill. Print null when the attribute is absent. An empty value stays a blank line, and --json still reports null or an empty string.
Contributor
|
@MaxWang007 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get attrprinted✓ Donewhen the attribute wasn't there, the same lineclickandfillprint on success. The daemon returnsvalue: nullin that case, and the plain-text formatter only handled strings, so it fell through to the generic success line.It now prints
nullfor a missing attribute. An empty attribute still prints a blank line, and--jsonis unchanged ("value": nullvs"value": ""). The MCP text output printsnulltoo instead of the raw JSON. I added a short note to theget attrdocs and skill reference.Fixes #1938
Testing:
cargo fmt --all -- --checkcargo clippy --locked -- -D warningscargo test --locked, including new unit tests for missing vs empty in plain text, JSON, and MCP output