Repository navigation
Conversation
The New Session request ran `agent-browser open about:blank --session <name>` with the dashboard server's environment, including AGENT_BROWSER_DASHBOARD. The child started a second dashboard server instead of opening the session, failed to bind the dashboard port, and exited 0, so the dashboard reported success for a session that never started. All three places where the dashboard runs the CLI now build the command with one helper that clears the dashboard variables. Co-authored-by: usesprocket[bot] <306702232+usesprocket[bot]@users.noreply.github.com>
Contributor
|
@Amronos is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The dashboard's New Session button (
POST /api/sessions) reports success, but no session appears and no browser opens.agent-browser dashboard startruns the dashboard server withAGENT_BROWSER_DASHBOARDandAGENT_BROWSER_DASHBOARD_PORTset.spawn_sessionrunsagent-browser open about:blank --session <name>with that environment. The child seesAGENT_BROWSER_DASHBOARDat startup and becomes a second dashboard server instead of runningopen. It cannot bind the dashboard port, which the parent holds, so it prints an error to a discarded stderr and exits 0. The handler then returns{"success":true,"session":"<name>"}.POST /api/execand the dashboard chat tool already clear these variables, so runningopen about:blank --session <name>through/api/execworks.Changes
cli_commandinstream/dashboard.rs. It builds the child CLI command withAGENT_BROWSER_DASHBOARD,AGENT_BROWSER_DASHBOARD_PORTandAGENT_BROWSER_STREAM_PORTremoved.spawn_session,exec_cliand the chat tool instream/chat.rsuse it, so the three places that run the CLI from the dashboard keep the same environment.cli_commandclears the dashboard variables.Written by Opus 5.5 (opus-5.5) through Sprocket.