[miguelnieto]

Summary

Brings the SQL editor pane up to the standard of MAT's own panes, and adds:

• a schema browser;
• "Open in SQL Editor" on MAT's object menus;
• cancel for running queries;
• date and time SQL functions.

Stacked on #121 (MAT 1.17 / Java 21 / Calcite 1.42). Until #121 is merged, this PR also shows its commit. Review only e1d5ea1, or see just this PR's changes. PR 3/3 (MCP server) builds on this one.

Editor

• Right-click menu: Run, Explain, Undo/Redo, Cut/Copy/Paste, Delete, Select All and Toggle Comment.
• Key bindings in their own context. F5 / Ctrl+Enter, F10, Ctrl+Space and Ctrl+/ are now workbench commands in a context that is a child of MAT's editor context. MAT binds F5, Ctrl+Enter and Ctrl+Space to its OQL commands, and before this change the workbench consumed those keys before the SQL editor saw them.
• Theme colors for the syntax (Preferences › Appearance › Colors and Fonts), with defaults for the dark theme. Line numbers are readable in the dark theme.
• "SQL Reference" tab: tables, virtual columns and functions open in a separate tab, so the current result stays open. The 30-line help comment the editor used to start with is now a short hint and a sample query.
• Completion pops up after typing . or ", not only on Ctrl+Space.
• Result rows show MAT's object icons.
• Reopening a result from the navigation history restores its query and runs it again, as the OQL pane does.
• Errors are underlined at the right place, also when a selection or Explain runs, and the underline is cleared by the next run.
• Cancel works. Cancel in the Progress view, or closing the tab, stops a running query. The heap object scan checks a per-query flag, QueryCancellation. Calcite itself only checks for cancel between result rows, so an aggregation could not be stopped before.

Schema browser

A toolbar toggle shows a tree beside the editor, listing:

• classes by package;
• classes with their subclasses (instanceof);
• thread stacks and functions.

Each class shows its columns and its this['@shallow'] / this['@retained'] sizes. Double-click inserts a name at the cursor, quoted where SQL needs it. The filter box lists matching tables; it is debounced and works from cached sorted names, so it stays fast on dumps with many classes.

Open in SQL Editor

"SQL › Open in SQL Editor" appears on the context menu of objects and classes in MAT's views (histogram, dominator tree, object lists, …). It adds a query for the selection to the SQL tab of the objects' own dump, selects it, and doesn't run it:

• objects: selected by address, one statement per class;
• a class row: all its instances;
• a class row of a partial histogram (Show Retained Set, a dominator tree grouped by class): only that row's objects.

SQL

• Date and time functions: toDateTime(x[, zone]), toEpochMillis, millisToDateTime, secondsToDateTime, toDuration.
  • They cover java.util.Date, java.sql.*, Calendar and the java.time types.
  • A Date changed with a deprecated setter, or a Calendar changed with set(...), can hold a stale time; these return null rather than a wrong time.
  • Durations don't overflow at Long.MAX_VALUE seconds.
• instanceof."java.lang.ref.Reference" accepts a full class name as one identifier. Identifiers are quoted by Calcite's own reserved words, not only SQL-92's: java.lang.ref doesn't parse unquoted, because REF is reserved.
• The SQL reference now uses instanceof.java.util.AbstractMap as its example. Heap dumps record superclasses but not interfaces, so instanceof.java.util.Map is always empty.
• CALCITE-1.42-QUERIES.md explains what Calcite 1.37–1.42 adds for heap queries.

Fixes

• Keys stopped working on GTK/Wayland. After a table result was shown, Backspace, Delete and the arrow keys were dropped, while letters still typed. MAT's "Retrieving view elements…" progress dialog opens and closes without getting focus, and SWT is then left with no active shell. The pane now reactivates the workbench window, which also fixes MAT's own OQL pane.
• The editor jumped when a query ran while it was scrolled to the end. JFace briefly lays the editor out taller during a toolbar relayout, and StyledText scrolls to fill the space. The scroll position is now restored after such a transient resize.
• Undo/Redo keys didn't work, and Cut/Copy could be disabled while text was selected.
• Closing a tab cleaned up badly:
  • a query that finished afterwards failed on the disposed editor;
  • closing the tab while the editor had focus left its key bindings active and the Cut/Copy/Paste handlers pointing at the closed editor.
• The pane leaked its title image and syntax colors.
• Removed debug output printed on stdout on every result refresh.

Testing

• ./mvnw verify with JDK 21: 69 tests pass, 1 skipped (@Ignore on main too). New tests cover the SQL generated for selections, the date functions, cancellation, result icons, instanceof names and reserved-word quoting.

• Checked by hand in MAT 1.17.0 on Linux (GTK/Wayland):

  • error underlines for a selection and for Explain;
  • closing a tab while its query runs;
  • key bindings after closing a tab;
  • the schema filter;
  • "Open in SQL Editor" with two dumps open.

  Cancel from the Progress view is covered by a unit test only.

🤖 Generated with Claude Code