Repository navigation
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Event names can match a Pod or an older Job with the same name. Use the involved object UID and the fetched Job namespace for both commands.
diiviikk5
force-pushed
the
fix-cli-job-event-identity
branch
from
October 27, 2026 20:57
c48f004 to
86e1fdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
vcctl job viewandvjobsfilter events using the Job name prefix. This can display events from a previous Job or a Pod with the same name, while excluding matching events without that prefix.Both commands now use the fetched Job's namespace and match
involvedObject.uidagainst the Job UID.Reproduced on
90125f9f6using actual CLI binaries against kind Kubernetes 1.36.4. Events were created for a deleted Job, its replacement, and a Pod with the same name. The original commands displayed all three; the fixed commands displayed only the replacement Job's events.Existing event filtering.
Which issue(s) this PR fixes:
No issue has been opened. Reproduction and evidence are included above.
Special notes for your reviewer:
TestGetEventsUsesJobIdentitycovers both commands, namespace selection, unrelated UIDs, and matching events without the name prefix.Package tests and vet passed after rebasing onto
40b9dca15on October 26. Live checks ran on October 20 and were not repeated after rebasing.AI assistance was used while preparing this contribution.
Does this PR introduce a user-facing change?