Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe Nuxt package now requires Node.js 22 or newer and accepts ChangesNuxt package compatibility
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1654 +/- ##
=======================================
Coverage 62.90% 62.90%
=======================================
Files 28 28
Lines 1903 1903
Branches 264 264
=======================================
Hits 1197 1197
Misses 706 706 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/nuxt/package.json`:
- Line 56: Restrict the firebase-admin peer dependency range in
packages/nuxt/package.json to versions below ^14.0.0, unless this package also
declares a Node 22+ engines requirement. Preserve support for the existing
^11.3.0, ^12.2.0, and ^13.0.1 ranges.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7f412c4b-8610-4bb9-94a3-5aba33cf87b1
📒 Files selected for processing (1)
packages/nuxt/package.json
|
Hope you are having a great summer time 😃 We have another dependency issue here with the latest firebase-admin package in nuxt-vuefire. Could we please integrate this? Thanks so much and have a wonderfull sunday! |
Widen the firebase-admin peer dependency range to include v14, matching firebase-functions 7.x which already accepts firebase-admin ^14.0.0. Fixes ERESOLVE when installing nuxt-vuefire alongside firebase-admin@14. firebase-admin v14 drops support for Node.js 18 and 20 (engines: node >=22), so declare the matching engines floor on nuxt-vuefire to prevent Node 20 consumers from installing an incompatible firebase-admin at runtime.
4e364d4 to
ed76e5c
Compare
|
Any news on this one? |
|
@posva |
|
Dear @posva I'm still patientely waiting for you to merge this commit |
|
Hello dear @posva 😄 Please, could you merge this into main and create a new release? Otherwise you could also add me as a contributor but I need this update... |
|
Can you at least give a timeframe? As I said, I would happily be helping you with maintaining this module. Also I already donated once this year, so please let me at least be able to use the latest modules of firebase etc.. Greetings |
What
Widens the
firebase-adminpeer dependency range ofnuxt-vuefireto include^14.0.0:Why
firebase-functions@7already acceptsfirebase-admin@^14.0.0as a peer, butnuxt-vuefiredoes not, so installing a project withfirebase-admin@14fails:The module only uses stable
firebase-adminAPIs (initializeApp,getAuth, session cookie verification, app-check), which are unchanged in v14 — the major was primarily dropping Node 18 support.🤖 Generated with Claude Code
Summary by CodeRabbit