Skip to content

feat(nuxt): allow firebase-admin 14 - #1654

Open
Tkkg1994 wants to merge 1 commit into
vuejs:mainfrom
Tkkg1994:fix/nuxt-firebase-admin-14
Open

Tkkg1994 wants to merge 1 commit into
vuejs:mainfrom
Tkkg1994:fix/nuxt-firebase-admin-14

Conversation

@Tkkg1994

@Tkkg1994 Tkkg1994 commented Jul 19, 2026 •

Copy link
Copy Markdown
Contributor

What

Widens the firebase-admin peer dependency range of nuxt-vuefire to include ^14.0.0:

- "firebase-admin": "^11.3.0 || ^12.2.0 || ^13.0.1",
+ "firebase-admin": "^11.3.0 || ^12.2.0 || ^13.0.1 || ^14.0.0",

Why

firebase-functions@7 already accepts firebase-admin@^14.0.0 as a peer, but nuxt-vuefire does not, so installing a project with firebase-admin@14 fails:

npm error Could not resolve dependency:
npm error peerOptional firebase-admin@"^11.3.0 || ^12.2.0 || ^13.0.1" from nuxt-vuefire@1.1.2

The module only uses stable firebase-admin APIs (initializeApp, getAuth, session cookie verification, app-check), which are unchanged in v14 — the major was primarily dropping Node 18 support.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Expanded compatibility by updating the declared minimum Node.js version to >= 22.
    • Expanded compatibility with additional supported Firebase Admin SDK versions (now includes ^14.0.0 alongside existing versions).

@coderabbitai

coderabbitai Bot commented Jul 19, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5ba65bd6-b980-4d53-9c92-8725c648f38c

📥 Commits

Reviewing files that changed from the base of the PR and between 4e364d4 and ed76e5c.

📒 Files selected for processing (1)
  • packages/nuxt/package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/nuxt/package.json

📝 Walkthrough

Walkthrough

The Nuxt package now requires Node.js 22 or newer and accepts firebase-admin versions ^11.3.0, ^12.2.0, ^13.0.1, or ^14.0.0.

Changes

Nuxt package compatibility

Layer / File(s) Summary
Set Node.js engine requirement
packages/nuxt/package.json
The package declares Node.js >=22 as its minimum runtime.
Expand firebase-admin peer range
packages/nuxt/package.json
The firebase-admin peer dependency now allows ^14.0.0 in addition to the existing version ranges.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: expanding Nuxt support to allow firebase-admin 14.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Jul 19, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/vuefire@1654

commit: ed76e5c

@codecov

codecov Bot commented Jul 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.90%. Comparing base (efec240) to head (ed76e5c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1654   +/-   ##
=======================================
  Coverage   62.90%   62.90%           
=======================================
  Files          28       28           
  Lines        1903     1903           
  Branches      264      264           
=======================================
  Hits         1197     1197           
  Misses        706      706           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/nuxt/package.json`:
- Line 56: Restrict the firebase-admin peer dependency range in
packages/nuxt/package.json to versions below ^14.0.0, unless this package also
declares a Node 22+ engines requirement. Preserve support for the existing
^11.3.0, ^12.2.0, and ^13.0.1 ranges.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7f412c4b-8610-4bb9-94a3-5aba33cf87b1

📥 Commits

Reviewing files that changed from the base of the PR and between efec240 and 4e364d4.

📒 Files selected for processing (1)
  • packages/nuxt/package.json

Comment thread packages/nuxt/package.json
@Tkkg1994

Copy link
Copy Markdown
Contributor Author

@posva

Hope you are having a great summer time 😃

We have another dependency issue here with the latest firebase-admin package in nuxt-vuefire. Could we please integrate this?

Thanks so much and have a wonderfull sunday!

Widen the firebase-admin peer dependency range to include v14, matching
firebase-functions 7.x which already accepts firebase-admin ^14.0.0.
Fixes ERESOLVE when installing nuxt-vuefire alongside firebase-admin@14.

firebase-admin v14 drops support for Node.js 18 and 20 (engines: node
>=22), so declare the matching engines floor on nuxt-vuefire to prevent
Node 20 consumers from installing an incompatible firebase-admin at
runtime.
@Tkkg1994
Tkkg1994 force-pushed the fix/nuxt-firebase-admin-14 branch from 4e364d4 to ed76e5c Compare July 21, 2026 19:35
@Tkkg1994

Copy link
Copy Markdown
Contributor Author

@posva

Any news on this one?

@Tkkg1994

Tkkg1994 commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

@posva
Sorry to bother you about this again, but is there anything I can do to help to speed this up? Thank you

@Tkkg1994

Copy link
Copy Markdown
Contributor Author

Dear @posva

I'm still patientely waiting for you to merge this commit

@Tkkg1994

Tkkg1994 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

Hello dear @posva 😄

Please, could you merge this into main and create a new release? Otherwise you could also add me as a contributor but I need this update...

@Tkkg1994

Copy link
Copy Markdown
Contributor Author

@posva

Can you at least give a timeframe? As I said, I would happily be helping you with maintaining this module.

Also I already donated once this year, so please let me at least be able to use the latest modules of firebase etc..

Greetings

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant