Skip to content

feat: rotate meeting join links - WPB-28499 - #5468

Merged
acv-w merged 7 commits into
developfrom
feat/rotate-meeting-link-WPB-28499
Nov 2, 2026
Merged

acv-w merged 7 commits into
developfrom
feat/rotate-meeting-link-WPB-28499

Conversation

@acv-w

@acv-w acv-w commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor
StoryWPB-28499 [iOS] Rotate the meeting join link

Issue

Meeting owners can replace a join link from Meeting link or Edit meeting, with an optional replacement password.

The form uses the standard Meetings password and confirmation controls. The link viewer fits its content and supports large-text scrolling.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Please make sure new localizations are translated once merged to develop.
We need 100% German translations before releasing.

New strings (English):

  • wireMeetings.link.generate = "Generate new link"
  • wireMeetings.link.consequence = "Any previous link to this meetings will be revoked and a new link will be created."
  • wireMeetings.link.creating = "Creating..."
  • wireMeetings.link.created = "New link created. Previous links no longer work."
  • wireMeetings.link.close = "Close"
  • wireMeetings.link.createError = "Could not create the meeting link. Please try again."

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Test Results

    4 files    255 suites   2m 28s ⏱️
1 546 tests 1 545 ✅ 1 💤 0 ❌
1 548 runs  1 547 ✅ 1 💤 0 ❌

Results for commit c3a50b3.

♻️ This comment has been updated with latest results.

Summary: workflow run #41460822582
Allure report (download zip): html-report-34901-feat_rotate-meeting-link-WPB-28499

@jullianm jullianm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@caldrian caldrian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the link-rotation API/repository wiring, password validation, duplicate-request protection, and stale-fetch handling. The WireCalling tests pass in CI, but WireDomainTests fails to compile because two handwritten MeetingsAPI doubles were not updated. The failure is directly caused by the new protocol requirement and needs fixing before approval. CI evidence: https://github.com/wireapp/wire-ios/actions/runs/40570494853/job/122423898943 . I did not rerun the full test suite locally.

@acv-w
acv-w requested a review from caldrian October 28, 2026 17:15

@caldrian caldrian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed c2debdb, including the v19 refresh request and response against the backend contract, repository mapping, both entry points, password validation, duplicate-request protection, stale-fetch handling, and the sheet changes. No new actionable findings.

The previously reported MeetingsAPI conformance issue is addressed in both handwritten notification test doubles. The current CI checks pass. This review is based on source inspection and existing CI results; I did not run the app or tests locally.

@acv-w
acv-w added this pull request to the merge queue Nov 2, 2026
Merged via the queue into develop with commit 489ec10 Nov 2, 2026
13 checks passed
@acv-w
acv-w deleted the feat/rotate-meeting-link-WPB-28499 branch November 2, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants