feat: show offline notice in conversation - WPB-25326 by caldrian · Pull Request #5473 · wireapp/wire-ios

caldrian · 2026-10-29T11:28:13Z

WPB-25326 [iOS] Show "No Internet" banner at the bottom of the conversation

Issue

While the device is offline, the open conversation now shows a notice: "You are offline. Your messages will be sent once you are online again." It's behind the developer flag offlinePendingMessages and builds on #5447 (offline pending messages), so it depends on it and will be rebased once that's merged.

Behavior

It's shown in any conversation that's open while offline, the same state that shows the NO INTERNET bar. It disappears when the device is back online.
If the newest messages are the self user's pending ones, the notice is shown above them. Otherwise it's shown below the newest message. It scrolls with the messages.

Implementation

It's only in the UI: an extra cell attached to one message's cells, the same way the date divider is added. Nothing is stored, so unread counts and the conversation list are unaffected and there's nothing to clean up after a restart.
ConversationMessageContext has a new offlineNotice value (above or below) that says where the cell goes. ConversationTableViewDataSource computes it from the network state and the pending messages.
ConversationContentViewController observes network availability like NetworkStatusViewController.

Testing

Turn on Developer settings → offlinePendingMessages and restart the app.

Open a conversation and go offline. The notice appears below the newest message.
Send a few messages while offline. The notice stays above them, and the first one shows the sender name.
Go online. The notice disappears and the messages are sent.
With the flag off, no notice is shown.

Checklist

Title contains a reference JIRA issue number like [WPB-XXX].
Description is filled and free of optional paragraphs.
Adds/updates automated tests.

UI accessibility checklist

The notice is a single accessibility element whose label is the full text.
Dynamic Type: the text uses fixed font sizes, matching the existing system message cell. To be checked with design.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0126T3TR7JLgpH6bwpF2wAWp

With offline pending messages, a text written after an image that is still waiting for its upload could be sent first once the image is older than the dependency cap. Also look up the self user's assets that are uploading or waiting to be sent when resolving dependencies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0126T3TR7JLgpH6bwpF2wAWp

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0126T3TR7JLgpH6bwpF2wAWp

An image or file waiting for its upload can't be cancelled, and Delete is hidden for pending messages. With offline pending messages it can wait for a long time, so allow deleting it locally while it's still uploading: the asset message is only sent after the upload, so nobody else has it. The upload is cancelled first, and the deletion runs on the sync context so it can't race with the send. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0126T3TR7JLgpH6bwpF2wAWp

…fline-pending-assets-WPB-26307

…fline-pending-assets-WPB-26307 # Conflicts: # wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/ConversationContentViewController+MessageDeletion.swift

…fline-pending-assets-WPB-26307

While offline (behind the offlinePendingMessages flag), the open conversation shows a notice that messages are sent once online again. It's placed above the messages the self user sent while offline, or below the newest message, and disappears when the device is back online. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0126T3TR7JLgpH6bwpF2wAWp

github-actions · 2026-10-29T11:29:06Z

Please make sure new localizations are translated once merged to develop.
We need 100% German translations before releasing.

New strings (English):

content.system.offline_notice.title = "You are offline."
content.system.offline_notice.message = "Your messages will be sent once you are online again."

github-actions · 2026-10-29T13:22:29Z

Test Results

0 tests 0 ✅ 0s ⏱️
0 suites 0 💤
0 files 0 ❌

Results for commit ba43a43.

♻️ This comment has been updated with latest results.

Summary: workflow run #41443125353
Allure report (download zip): html-report-34900-feat_offline-system-message-WPB-25326

…fline-pending-assets-WPB-26307

…e-system-message-WPB-25326

datadog-wireapp · 2026-10-30T14:08:04Z

⚠️ Warnings

Your PR has warnings. Tests failed — unable to determine if these are from required jobs.

🧪 1 Test failed in 1 job

Test Pull Request Changes | upload-test-results-datadadog — ❄️ 1 known flaky test · 🔄 may pass on retry

View more details · View in GitHub Actions

↳ ❄️ Known flaky: testThatItReturnsLastMessageIfLastMessagesAreTextsAndSentBySelfUser from WireDataModelTests.ZMConversationTests

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 3b2ed87 | Docs | View more details | Give us feedback!}

Copilot

🟡 Changes recommended

The offline notice has unresolved VoiceOver and Dynamic Type gaps, is absent in empty conversations, and causes quadratic pending-message scans during rebuilds.

4 open issues

What changed in this PR

Adds a conversation-level offline notice behind offlinePendingMessages, building on #5447’s pending-message behavior. The PR also extends pending asset deletion and send ordering.

Changes:

Observe network availability and position the notice above trailing pending messages or below the newest message.
Add localized notice text and tests for notice placement.
Allow local deletion of uploading assets and include older pending assets in message dependencies.

File	Description
`wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/ConversationTableViewDataSource.swift`	Computes notice visibility and placement.
`wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/ConversationContentViewController+OfflineNotice.swift`	Observes network state behind the developer flag.
`wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/ConversationContentViewController+MessageDeletion.swift`	Generalizes pending deletion to supported message types.
`wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/ConversationContentViewController.swift`	Starts and retains network observation.
`wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/Cells/ConfigurationMessageCell/ConversationMessageSectionController.swift`	Inserts notice cells and preserves sender headers.
`wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/Cells/ConfigurationMessageCell/Components/ConversationOfflineNoticeCell.swift`	Defines the notice’s appearance and accessibility label.
`wire-ios/Wire-iOS/Resources/Localization/Base.lproj/Localizable.strings`	Adds offline notice text.
`wire-ios/Wire-iOS/Generated/Strings+Generated.swift`	Adds generated localization accessors.
`wire-ios/Wire-iOS Tests/ConversationMessageCell/ConversationMessageSectionControllerTests.swift`	Tests notice placement and cell grouping.
`wire-ios-request-strategy/Sources/Protocols/OTREntityTests+Dependency.swift`	Tests dependencies on older uploading assets.
`wire-ios-request-strategy/Sources/Helpers/ZMMessage+Dependency.swift`	Includes pending assets in send dependencies.
`wire-ios-data-model/Tests/Model/Messages/ZMAssetClientMessageTests.swift`	Tests pending asset deletion eligibility and behavior.
`wire-ios-data-model/Source/Model/Message/ZMAssetClientMessage+Deletion.swift`	Adds shared pending-deletion support and asset cancellation.
`wire-ios-data-model/Source/Model/Message/ConversationMessage.swift`	Uses shared pending-deletion eligibility.

_{Review effort: Balanced}

+
+    override init(frame: CGRect) {
+        super.init(frame: frame)
+        lineView.isHidden = true


+        let textColor = SemanticColors.Label.textDefault
+        let attributedText = NSMutableAttributedString(
+            string: Strings.title,
+            attributes: [.font: UIFont.systemFont(ofSize: 14, weight: .semibold), .foregroundColor: textColor]


            searchQueries: searchQueries,
-            previousMessageIsKnock: previousMessage?.isKnock == true
+            previousMessageIsKnock: previousMessage?.isKnock == true,
+            offlineNotice: offlineNoticePosition(at: index, messages: messages)


+        let pendingMessageCount = messages.prefix { message in
+            Message.isNormal(message) && message.deliveryState == .pending && message.sender?.isSelfUser == true
+        }.count


acv-w

Please fix the empty-state notice and accessibility issues before merge.

acv-w · 2026-11-02T10:13:09Z

            searchQueries: searchQueries,
-            previousMessageIsKnock: previousMessage?.isKnock == true
+            previousMessageIsKnock: previousMessage?.isKnock == true,
+            offlineNotice: offlineNoticePosition(at: index, messages: messages)


issue (P2): An empty conversation creates no message sections, so it never shows this notice while offline. Please add a UI-only section for the empty state.

acv-w · 2026-11-02T10:13:09Z

+
+    override init(frame: CGRect) {
+        super.init(frame: frame)
+        lineView.isHidden = true


issue (P2): Please set isAccessibilityElement = true on this view. The base cell hides its text and image from accessibility, so the assigned label is not exposed to VoiceOver.

acv-w · 2026-11-02T10:13:09Z

+        let textColor = SemanticColors.Label.textDefault
+        let attributedText = NSMutableAttributedString(
+            string: Strings.title,
+            attributes: [.font: UIFont.systemFont(ofSize: 14, weight: .semibold), .foregroundColor: textColor]


issue (P2): These fixed 14-point fonts do not scale with Dynamic Type. Please use scaled fonts and update the text when the content-size category changes.

…fline-pending-assets-WPB-26307

…e-system-message-WPB-25326

…reapp/wire-ios into feat/offline-system-message-WPB-25326

caldrian and others added 10 commits October 28, 2026 14:15

docs: add pending messages notes and asset follow-up sketch - WPB-26307

64e40cb

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0126T3TR7JLgpH6bwpF2wAWp

docs: update asset follow-up notes with test results - WPB-26307

ccdcef5

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0126T3TR7JLgpH6bwpF2wAWp

Delete PENDING_MESSAGES_NOTES.md

59b7cee

docs: add asset PR tests and limitation to notes - WPB-26307

6487724

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0126T3TR7JLgpH6bwpF2wAWp

Merge branch 'feat/pending-message-foundation-WPB-26307' into feat/of…

baa3807

…fline-pending-assets-WPB-26307

Merge branch 'feat/pending-message-foundation-WPB-26307' into feat/of…

49bc79d

…fline-pending-assets-WPB-26307 # Conflicts: # wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/ConversationContentViewController+MessageDeletion.swift

Merge branch 'feat/pending-message-foundation-WPB-26307' into feat/of…

18a3cdc

…fline-pending-assets-WPB-26307

github-actions Bot assigned caldrian Oct 29, 2026

caldrian marked this pull request as ready for review October 29, 2026 13:09

caldrian requested review from a team, jullianm and samwyndham and removed request for a team October 29, 2026 13:09

github-actions Bot added the Messenger Jira component label Oct 29, 2026

caldrian requested review from a team and David-Henner and removed request for a team and samwyndham October 29, 2026 13:09

caldrian added 2 commits October 30, 2026 14:44

Merge branch 'feat/pending-message-foundation-WPB-26307' into feat/of…

8444b56

…fline-pending-assets-WPB-26307

Merge branch 'feat/offline-pending-assets-WPB-26307' into feat/offlin…

3b2ed87

…e-system-message-WPB-25326

jullianm requested a balanced review from Copilot November 2, 2026 08:29

Copilot started reviewing on behalf of jullianm November 2, 2026 08:30

View session

Copilot AI reviewed Nov 2, 2026

View reviewed changes

acv-w requested changes Nov 2, 2026

View reviewed changes

caldrian added 3 commits November 2, 2026 13:13

Merge branch 'feat/pending-message-foundation-WPB-26307' into feat/of…

b0c870b

…fline-pending-assets-WPB-26307

Merge branch 'feat/offline-pending-assets-WPB-26307' into feat/offlin…

1fd3008

…e-system-message-WPB-25326

Merge branch 'feat/offline-system-message-WPB-25326' of github.com:wi…

ba43a43

…reapp/wire-ios into feat/offline-system-message-WPB-25326

Navigation Menu

Repository navigation

feat: show offline notice in conversation - WPB-25326 - #5473

feat: show offline notice in conversation - WPB-25326#5473
caldrian wants to merge 15 commits into
feat/pending-message-foundation-WPB-26307from
feat/offline-system-message-WPB-25326

caldrian commented Oct 29, 2026 •

edited by github-actions Bot

Loading

Uh oh!

github-actions Bot commented Oct 29, 2026

Uh oh!

github-actions Bot commented Oct 29, 2026 •

edited

Loading

Uh oh!

datadog-wireapp Bot commented Oct 30, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

acv-w left a comment

Uh oh!

acv-w Nov 2, 2026

Uh oh!

acv-w Nov 2, 2026

Uh oh!

acv-w Nov 2, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

caldrian commented Oct 29, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Testing

Checklist

UI accessibility checklist

Uh oh!

github-actions Bot commented Oct 29, 2026

Uh oh!

github-actions Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

datadog-wireapp Bot commented Oct 30, 2026

⚠️ Warnings

ℹ️ Info

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

acv-w left a comment

Choose a reason for hiding this comment

Uh oh!

acv-w Nov 2, 2026

Choose a reason for hiding this comment

Uh oh!

acv-w Nov 2, 2026

Choose a reason for hiding this comment

Uh oh!

acv-w Nov 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

caldrian commented Oct 29, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Oct 29, 2026 •

edited

Loading