Repository navigation
Conversation
pleasew8t
requested review from
SEJeff,
bemic,
djb15,
evan-gray,
johnsaigle,
kcsongor,
mdulin2 and
panoel
as code owners
November 12, 2026 10:29
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request brings some improvements to the Sui transfer verifier in preparation for enabling it.
Add optional digest check and return error in case of zero message publications
ProcessDigestto return an error when no outbound transfers were found. In the happy path,ProcessDigestshould only ever receive digests for transactions that contain message publications.GetTransactionSui gRPC implementation. Unlikely to be the case, but the point is that the digest returned from the RPC server must match the one requested.Ensure RPC errors result in early-exits instead of being ignored
Handle the case where same-tx tokens are created and transferred
InputVersionisnil, it is assumed that the asset was created in this transaction.Bump sui-go-sdk version to 1.3.1
Review Notes
The changes are mostly hardening certain checks, and making sure certain failures are reported more consistently. The PR shouldn't introduce any hard functional changes.