Repository navigation
Merge branch 'main' into feature/portal - #69
Closed
rashmithachamikara wants to merge 7 commits into
Closed
rashmithachamikara wants to merge 7 commits into
rashmithachamikara wants to merge 7 commits into
Conversation
Updated: - [api/consent-management-API.yaml](D:\wso2\openfgc\api\consent-management-API.yaml) - `sort` docs now match handler behavior: field-only form defaults to `desc`, max 3 items, and existing default/example remain aligned. - `ConsentGroupIDsResponse.groupIds` now has `uniqueItems: true`. - [consent-server/internal/consent/handler.go](D:\wso2\openfgc\consent-server\internal\consent\handler.go) - Repeated `sort` query params are now rejected with `400` before parsing. - [consent-server/internal/consent/service.go](D:\wso2\openfgc\consent-server\internal\consent\service.go) - Removed raw `user_id` from the group-id lookup info log. - Internal store errors now return the generic `ErrorInternalServerError` message instead of leaking `err.Error()`. - [consent-server/internal/consent/store.go](D:\wso2\openfgc\consent-server\internal\consent\store.go) - Changed the search data query to order from a `SELECT DISTINCT ...` subquery, which keeps the `validityTime` CASE-based ordering PostgreSQL-safe.
…ements Consent read enhancements: group-ids, sort
- Get changes sort feature to portal branch
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (10)
📒 Files selected for processing (94)
📝 WalkthroughSummary
WalkthroughAdds a Go BFF with configuration, health endpoints, CORS and correlation middleware, allowlisted upstream proxying, current-user consent approval/revocation flows, OpenAPI documentation, container tooling, and integration tests. Adds a React/Vite consent portal with routing, localization, typed API access, registry/detail pages, approval and revocation dialogs, pagination, status handling, and frontend tests. Adds backend and frontend CI workflows plus development configuration files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get the sort features to the portal branch