Repository navigation
CP-315389: Stop lldpd when the last interface leaves the LLDP scope - #7376
Open
changlei-li wants to merge 2 commits into
Open
changlei-li wants to merge 2 commits into
changlei-li wants to merge 2 commits into
Conversation
networkd started lldpd on the first LLDP-enabled interface but only stopped it on shutdown, so with LLDP disabled on every interface lldpd kept running and kept serving the LLDP-MIB over SNMP. Move starting lldpd, applying the settings and enabling or disabling the port from set_conf into Scope.add and Scope.remove, so they run under the same lock as the scope change. Then stop lldpd when the last interface is removed from the scope; the next interface added starts it again. Signed-off-by: Changlei Li <changlei.li@citrix.com>
When no interface has LLDP enabled, lldpd is not running, so pushing the management address fails with "Service not running" each time the address changes. This is expected, so only warn when an interface is in the LLDP scope. Signed-off-by: Changlei Li <changlei.li@citrix.com>
Member
Author
|
Manual test: Auto tests: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
networkd started lldpd on the first LLDP-enabled interface but only stopped it on shutdown, so with LLDP disabled on every interface lldpd kept running and kept serving the LLDP-MIB over SNMP.
Move starting lldpd, applying the settings and enabling or disabling the port from set_conf into Scope.add and Scope.remove, so they run under the same lock as the scope change. Then stop lldpd when the last interface is removed from the scope; the next interface added starts it again.