Repository navigation
CA-432914: Don't let clusterd tracing setup fail Cluster_host.enable - #7379
Open
MarkSymsCtx wants to merge 1 commit into
Open
MarkSymsCtx wants to merge 1 commit into
MarkSymsCtx wants to merge 1 commit into
Conversation
Cluster_host.enable pushed the tracing configuration to xapi-clusterd before enabling it, and a failure there failed the whole enable. A clusterd waiting for quorum leaves that RPC unanswered: on a pool booting after an unclean shutdown the coordinator's enable blocked for 6m40s, then failed with Observer_error(0), and the GFS2 SR stayed unplugged. Tracing is not a precondition for clustering. Configure it once clusterd is enabled, and only warn if that fails. Signed-off-by: Mark Syms <mark.syms@citrix.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MarkSymsCtx
requested review from
GabrielBuica,
LunfanZhang,
last-genius,
mg12,
minglumlu and
psafont
November 6, 2026 09:31
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cluster_host.enablepushed the tracing configuration to xapi-clusterd (Xapi_observer.initialise_observer) before enabling it, and any failure there failed the whole enable.xapi-clusterd handles local calls one at a time. When it is waiting for quorum, which is normal while a pool's hosts are coming back up, the observer call queues behind that wait. We saw a pool boot where the coordinator's enable blocked for 6m40s on
Observer.set_trace_log_dirand then failed withObserver_error(0). The enable was abandoned, so its GFS2 SR could not be plugged.Tracing is not a precondition for clustering. This configures it once clusterd has been enabled (and after a join), and only logs a warning if that fails.
Testing:
test_enable_survives_observer_failure: with a clusterd whose observer calls fail, the enable succeeds and clusterd is enabled before tracing is configured. Without the fix it fails with the sameObserver_error(0)seen in the field.test_clustering(46 tests) passes.🤖 Generated with Claude Code