Repository navigation
Preserve spaces in mapped credentials - #54
Closed
bensynapse wants to merge 1 commit into
Closed
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
Query escaping turns spaces in mapped credentials into literal plus signs. Use URL user information encoding to preserve their values through BuildURL and FromMap.
kenshaw
pushed a commit
that referenced
this pull request
Oct 10, 2026
Query escaping turns spaces in mapped credentials into literal plus signs. Use URL user information encoding to preserve their values through BuildURL and FromMap. From #54 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Member
|
Thank you, Ben. This is on main as fffaa03, with you as the author, and it ships in v0.49.1: https://github.com/xo/dburl/releases/tag/v0.49.1 |
Contributor
Author
|
Thanks for shipping the fix in v0.49.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
FromMapchanges a mapped passwordp wintop+wbecauseBuildURLescapes credentials as query components.Use URL user information encoding so usernames and passwords retain their values.
Twenty cases cover both sets of component names, spaces, literal plus signs, reserved characters, Unicode, and empty passwords.
Ten cases fail against the original source.
go test ./...,go vet ./..., and the pinnedgolangci-lint run ./...pass.The full suite also passes with race detection. Only
dburl.goanddburl_test.gochange.