Repository navigation
feat(send): the designer's sprout animation, with its failure branches - #1911
Open
juanky201271 wants to merge 9 commits into
Open
juanky201271 wants to merge 9 commits into
juanky201271 wants to merge 9 commits into
Conversation
…branches The sending screen tells each step on one drawing: the sprout grows while creating, a paper plane flies the mixnet route, waits in the mempool and fills the badge per confirmation. A TEX send draws a second plane. A send that fails ends where it is: the sprout wilts when it could not be created, the plane falls from a mix node when it could not be sent, and a clock closes it when it expires in NYM or in the mempool. The error can be copied or mailed to support. A send that failed to send and turns up in the mempool or a block goes on, since the screen shows the real state. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No effect disables exhaustive-deps any more, and the hooks that receive a shared value write it through set, which the jest mock now offers too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Visual review —
|
The ring and its sparks reach past the drawing, and Android clips an Svg to its own box whatever its overflow says. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
/visual-accept |
Co-authored-by: karentaponte <190538197+karentaponte@users.noreply.github.com>
Contributor
|
Baseline accepted from run |
The leaves, the coin and its ring vanished on Android while they moved. They were drawn in Svgs scaled by a viewBox with a negative origin, each inside an Animated.View whose transform changed every frame. The sprout is now one 300 x 220 Svg with the parts in a scaled group, and each moving part animates its group's matrix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Buying ZEC, Maya and THORChain route on a memo that exchanges and token transfers cannot add. From the designer's proposals 3, 4 and 6: - Routes: a memo route says so under its price; the others say "Address only". Paid with a token, the address-only route is selected when it is within 1% of the best; "Best" does not move. - Review: a "How you pay" row, and with a token a checkbox before the address is requested. - Deposit: a token paid to Maya or THORChain gets a note instead of the QR, a plain memo hint and no hex copy. The QR caption says when it carries only the address, and NEAR and Flashnet deposits get a note for exchange withdrawals on every network. Swap.tsx loses its exhaustive-deps disable for the React Compiler gate: the USD fill-in runs when the price changes, as before, adjusted during render. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…labs/zingo-mobile into feat/send-sprout-animation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The sending screen now follows the designer's sprout animation (mockup), for a send and for a shield, and it shows the real state of the transaction.
For the designer to test on a device
The normal path shows up on any send. Failures are hard to provoke on a real wallet; the
Failed,Failed SendingandExpiredstories show how each one ends.Where it differs from the mockup
Behaviour
SentMarkis gone. The illustration's colours are inapp/theme/sendArt.ts.The motion has not been run on a device yet, only in unit tests and static captures. The es, pt, ru and tr strings are machine-written and worth a read.
Checklist
UI changes (skip if this PR touches no screen or component):
app/themeand the shared primitives and widgets (DESIGN.md, "Components"); nofontSize, radius, colour or icon size by hand.DESIGN.mdchanges in this PR (CI fails whenapp/themevalues change without it)./visual-acceptonly after reading the report.Also in this PR: memo routes, from the designer's swap proposals 3, 4 and 6
Buying ZEC, Maya and THORChain route on a memo that exchanges and token transfers cannot add.
Swap.tsxloses its exhaustive-deps disable for the React Compiler gate. The USD fill-in still runs only when the price changes.The sprout now draws in one 300 x 220 Svg (no viewBox-scaled layers), with each moving part animating its group's matrix: the leaves, coin and ring vanished on Android while they moved.
🤖 Generated with Claude Code