Repository navigation
Conversation
Visual review — ✅ matches baselineHead vs |
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
zancas
force-pushed
the
fix/1910-review
branch
from
November 10, 2026 05:21
605804c to
7b5c851
Compare
…r kinds Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…he Pools screen Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the five review findings on #1910. It targets the branch of #1910.
Changes
app/walletholds one module for each domain:address,balance,pool,send,transferandkeys. Thetypes,enumsandclassesmodules are deleted.app/walletimports neitherapp/AppStatenorapp/walletBackend. Both of them importapp/wallet.@app/AppStatebarrel exports its own names only. Each wallet name has one import path,@app/wallet/<domain>.ValueTransferKind,ValueTransferStatus,Pool,AddressKind,AddressScope. The string values are unchanged.WalletErrorInfois a discriminated union. The'chain'kind carrieswalletChain.WalletErrorInfoandDeleteWalletContextreturn toapp/AppState/types.FilterKindmoves toscreens/History/components/Filters.tsx.LoadingAppcalls the existingisViewingKey.TransactionType,TxDetailType,TransactionTypeEnumandAddressUnifiedTypeEnumhad zero users and are deleted.Tests
scripts/module_rules.tsholds five pure functions. Each function returns a discriminated union.__tests__/moduleRules.unit.tstests the functions on inline sources.__tests__/walletModule.unit.tsapplies the functions to the repository. Its five tests failed on the head of refactor(wallet): consolidate wallet enums and types into domain-grouped files #1910, one test for each finding.tsc,eslint,prettier --checkand all 285 Jest suites pass locally.Out of scope
The five classes in
app/walletremain classes. The change of each class to a type with functions is a separate task.🤖 Generated with Claude Code