Repository navigation
Swap: only the coins travel on a flip; History: a sprout for an empty wallet - #1916
Open
juanky201271 wants to merge 8 commits into
Open
juanky201271 wants to merge 8 commits into
juanky201271 wants to merge 8 commits into
Conversation
…outes, fees under it - The flip starts on the press, rewound before the state changes, so the flipped layout no longer paints its end state first. Reduce motion is read once. - Only the coin chips travel, in a layer over both cards; words and numbers fade in place, so nothing hides at the seam and the height holds. - A flip keeps the chosen coin when the other direction's catalog has it, instead of falling back to BTC. - The whole Provider row is the button, with a chevron and no underline; the fees sit under it, said as Review says them (routeFeeValue), with swap.tip-fees on the info icon. - While a price is on its way the ring keeps its place and Provider reads "Getting a price…". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… Receive ZEC No activity yet: the sprout tries to stand up, can't, and settles back down, while the fallen leaves breathe and one that got away drifts. Still under reduce motion. Receive ZEC opens the Receive tab. A filter that empties the list keeps "Nothing here yet." Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
path.relative gave backslashes, git ls-tree answers with forward slashes, so no changed file was found in the base: every base counted 0 bailouts and any touched file with old ones failed locally. CI on Linux was unaffected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Visual review —
|
- Empty history: the sprout gets room for its moving leaves and shrinks to 0.68 pt per unit; the title no longer drops its last word; no filter button or filter bar while there is nothing to filter. - Flip: the animation starts once the flipped direction has committed, its ends are held still while it runs, and only the words that differ cross-fade, both versions stacked so the cells keep their size. - InfoTooltip: measured unseen first, then mounted once in place, so it no longer opens in one spot and jumps. - Deposit for a token with a memo: one banner for both rules (a wallet with memos, the network) instead of two. - Provider row: name, shield, time and chevron grouped 4 apart; the fees row sits in the same block, 24 high. - FullPanel clears a tall footer by its measured height, so the review's last rows are reachable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A token from another wallet cannot carry their memo: it travels only through the router contract, which no wallet's Send calls, and a plain transfer to the vault is neither seen nor refunded (65 USDT were lost that way). Those routes are listed as unavailable with the reason; a chain's own coin keeps them. The soft preference for an address-only route within 1% is gone with them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…zingo-mobile into feat/swap-screen-flip
Every feature line was checked against the code. Building now says where Node comes from and that swaps need SWAPKIT_API_KEY before yarn install; Testing lists the checks CI runs on a pull request, the compiler ratchet included; visual review says how /visual-accept records a baseline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two designer artifacts.
Swap screen
loadCatalogkeeps the selected token when the other direction's catalog has it. It used to fall back to BTC, so USDT was lost.routeFeeValue, now shared with Review), withswap.tip-feeson the info icon.History, empty wallet
Tooling
check:compiler:changednever found the base files on Windows: backslash paths vsgit ls-tree. Every base counted 0, so any touched file with old bailouts failed locally. Fixed with forward-slash paths. CI on Linux was unaffected.Checks
origin/devVisual baselines will change (Swap and the new EmptySprout story).
🤖 Generated with Claude Code