Repository navigation
Keep the mixnet across a send retry on another server - #1917
Open
juanky201271 wants to merge 1 commit into
Open
juanky201271 wants to merge 1 commit into
juanky201271 wants to merge 1 commit into
Conversation
The send retry switched servers through setServerOption, which reopens the wallet: a new zingolib client, born Unattached. configure() did not re-arm the mixnet because the session already counted as armed, so the retried send refused with "the Nym mixnet is not enabled" while the header still read ready until the next 30 s poll (Beta 346 report). - The retry now moves the open wallet with changeServer, the same path the runtime server recovery uses, so the client keeps its mixnet. - setServerOption re-arms the mixnet after reopening the wallet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Visual review — ✅ matches baselineHead vs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beta 346 (Android): a send failed with
the Nym mixnet is not enabledwhile the header readready.Cause. The first attempt failed on DNS, and
settleSendretried on another server throughsetServerOption. That reopens the wallet (loadExistingWallet→init_from_bytes), which creates a new zingolib client inUnattached.configure()didn't re-arm the mixnet becausemixnetOnlinewas already true, so the retry was refused. The header kept showingreadyuntil the next 30 s poll.Fix
changeServer(newswitchServerForRetry), the same pathrecoverServeruses, so the client keeps its mixnet. The dial and persist steps are shared withactivateReachableServer(moveToServer).setServerOption(Settings) callswalletReopened()after reopening the wallet, which re-arms the mixnet for the new client.Tests
switchServerForRetry.Not covered here: when
init_from_bytesfails it has already dropped the old client, sosetServerOption's fallbackchangeServer(old)has no client to act on.🤖 Generated with Claude Code