Skip to content

fix: clock reactivity - #1918

Merged
dorianvp merged 3 commits into
devfrom
fix/clock-reactivity
Nov 10, 2026
Merged

dorianvp merged 3 commits into
devfrom
fix/clock-reactivity

Conversation

@dorianvp

@dorianvp dorianvp commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Wall clock and mixnet journal reads in render go through useSyncExternalStore stores, so the React Compiler's memo caches invalidate when they change and the frozen relative times, the swap delete button and the Doctor's journal repaint.

Closes #1889

@github-actions

Copy link
Copy Markdown

Visual review — ✅ matches baseline

Head vs visual/__baseline__. Open the review page — Current, Animations, and Image diffs tabs.

@juanky201271

Copy link
Copy Markdown
Contributor

Fixes all five cases in #1889. Three small things:

  1. clock.ts can lag real time by up to ~2 min: the value is floored to the minute and the 60 s interval isn't aligned to the minute boundary. SyncLine had 30 s precision before; now "just now" can last ~3 min, and falling-behind / the 30 min deposit warning come up to 2 min late. Checking every 10–15 s while still notifying only on a minute change fixes it.
  2. bucket only moves in strike, so after a stretch with no readers the first one reads a stale minute for up to 60 s. Recompute it in subscribe when the first listener joins.
  3. Add Closes #1889 so the issue closes on merge.

@dorianvp
dorianvp merged commit d8a6040 into dev Nov 10, 2026
15 checks passed
@dorianvp
dorianvp deleted the fix/clock-reactivity branch November 10, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

React Compiler: clock and journal reads frozen since #1885

2 participants