[Alexx3890]

Related Issue / Discussion

Fixes Issue #162.

Relates to open PRs #163 and #182 (see details below).

Changes

Please list the central functionalities that have been changed:

• Modified WeatherRoutingTool/algorithms/isochrone.py

  • Fixed broken logger.info() calls in get_dist() by adding %s format specifiers so distance, speed, and time values are correctly included in log output instead of being silently dropped.

• Modified WeatherRoutingTool/algorithms/isofuel.py

  • Fixed the logger.info() call in determine_timespread() to use %s formatting for delta_time.

• Modified tests/test_ship.py

  • Added missing commas in the message NumPy array definitions within test_shipparams_get_element and test_shipparams_get_single.
  • This prevents unintended implicit string literal concatenation ('Error' 'OK' → 'ErrorOK') and restores the expected four-element test arrays.

Further Details

Summary

This PR resolves two small, mechanical bugs:

1. Logger %s Formatting Bugs

In isochrone.py and isofuel.py, some logger.info() calls passed values as additional arguments without providing corresponding %s placeholders.

For example:

logger.info('dist=', dist)

and:

logger.info('delta_time', delta_time)

Python's standard logging module uses %-style formatting for additional arguments. Without a corresponding format specifier, the supplied values are not included in the resulting log message.

These calls have been corrected to:

logger.info('dist=%s', dist)

and:

logger.info('delta_time: %s', delta_time)

This ensures that the relevant distance, speed, time, and delta_time values are properly displayed in the logs.

2. Test Array Comma Typo

In tests/test_ship.py, the message arrays in test_shipparams_get_element and test_shipparams_get_single contained:

'Error' 'OK'

without a separating comma.

Python implicitly concatenates adjacent string literals, resulting in:

'ErrorOK'

instead of two separate elements.

This caused the array to contain only three elements instead of the expected four. Adding the missing comma restores the intended array:

['OK', 'OK', 'Error', 'OK']

and fixes the corresponding test input.

Note on Overlapping PRs #163 and #182

I am aware that open PRs #163 and #182 also address the test_ship.py comma typo. Both appear to be currently inactive.

This PR combines that existing test-data fix with the logger formatting corrections related to Issue #162.

If maintainers prefer to merge #163 or #182 for the test fix separately, I am happy to rebase or isolate the logger-related changes into an independent PR.

Dependencies

None (no new dependencies required).

Testing

The affected test suite was run to verify the changes. The test-data correction ensures that the existing ship parameter tests operate on the intended four-element input arrays.

PR Checklist

In the context of this PR, I:

• have (already previously) filled the [52North Contributor License Agreement](https://52north.org/software/licensing/cla-guidelines/) and received positive feedback on this matter
• have filled the [52North Contributor License Agreement](https://52north.org/software/licensing/cla-guidelines/) and am waiting for feedback
• provide unit tests embedded in the WRT test framework (WeatherRoutingTool/tests) that allow the simple testing of the new/modified functionalities. All (previous and new) unit tests execute without new error messages.
• ensure that the [code formatter](https://github.com/52North/WeatherRoutingTool/blob/main/flake8.sh) runs without errors/warnings
• ensure that my changes follow the [WRT's guidelines for contributing](https://52north.github.io/WeatherRoutingTool/source/contributing.html) at the time of the contribution

[Copilot]

🟢 Approval recommended

The changes are small, targeted fixes aligned with the issue/description, with only an optional logging-style improvement noted.

Pull request overview

This PR addresses Issue #162 by fixing Python logging calls that were dropping/triggering formatting errors due to missing %s placeholders, and by correcting a subtle test-data bug caused by implicit string literal concatenation in tests/test_ship.py.

Changes:

• Fix logger.info() argument formatting in get_dist() (isochrone.py) so dist/time/bs values are actually emitted.
• Fix logger.info() formatting in determine_timespread() (isofuel.py) so delta_time is included in logs.
• Add missing commas in tests/test_ship.py message arrays to prevent 'Error' 'OK' from becoming 'ErrorOK'.

File summaries

File	Description
WeatherRoutingTool/algorithms/isofuel.py	Corrects logger.info() formatting for delta_time (and keeps time-spread logging adjacent).
WeatherRoutingTool/algorithms/isochrone.py	Corrects logger.info() formatting so computed distance/time inputs are logged correctly.
tests/test_ship.py	Fixes missing commas in test message arrays to prevent implicit string concatenation.

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[kdemmich]

Dear user,
thank you for your interest in contributing to our WRT! I would like to point you to our guidelines for software contributions which require to follow 52 North's CLA guidelines for all PRs and, in particular, fill the 52°North Contributor License Agreement. As long as this has not been filled, I can not assign you to any issues or merge any PRs. Please don't hesitate to contact me in case of related questions.