Skip to content

fix: add missing commas in test_ship.py and fix logger string formatting #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Alexx3890 wants to merge 3 commits into from
Closed

fix: add missing commas in test_ship.py and fix logger string formatting #208

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14b32f1
fix: add missing commas in test_ship.py and fix logger string formatting
Alexx3890 Sep 17, 2026
ed09fe2
refactor: use %s formatting for time spread logging in determine_time…
Alexx3890 Sep 17, 2026
ccf9e90
Merge branch 'main' into fix/tier-2-tier-3
Alexx3890 Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions WeatherRoutingTool/algorithms/isochrone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@ def check_isochrones(self, route: RouteParams):

def get_dist(self, bs):
dist = self.delta_time * bs
logger.info('dist=', dist)
logger.info('delta_time=', self.delta_time)
logger.info('bs=', bs)
logger.info('dist=%s', dist)
logger.info('delta_time=%s', self.delta_time)
logger.info('bs=%s', bs)
return dist

def get_delta_variables(self, boat, wind, bs):
Expand Down
2 changes: 1 addition & 1 deletion WeatherRoutingTool/algorithms/isofuel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def determine_timespread(self, delta_time):
"""
stddev = np.std(delta_time)
mean = np.mean(delta_time)
logger.info('delta_time', delta_time.to('hour'))
logger.info('delta_time: %s', delta_time.to('hour'))
logger.info('spread of time: ' + str(mean.to('hour')) + '+-' + str(stddev.to('hour')))
Comment thread
Alexx3890 marked this conversation as resolved.
Outdated

def update_time(self):
Expand Down
4 changes: 2 additions & 2 deletions tests/test_ship.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def test_shipparams_get_element(self):
salinity = np.array([6.4, 6.5, 6.41, 6.42])
water_temperature = np.array([6.7, 6.8, 6.71, 6.72])
status = np.array([1, 2, 2, 3])
message = np.array(['OK', 'OK', 'Error' 'OK'])
message = np.array(['OK', 'OK', 'Error', 'OK'])

sp = ShipParams(fuel_rate=fuel, power=power, rpm=rpm, speed=speed, r_wind=rwind, r_calm=rcalm, r_waves=rwaves,
r_shallow=rshallow, r_roughness=rroughness, wave_height=wave_height,
Expand Down Expand Up @@ -105,7 +105,7 @@ def test_shipparams_get_single(self):
salinity = np.array([6.4, 6.5, 6.41, 6.42])
water_temperature = np.array([6.7, 6.8, 6.71, 6.72])
status = np.array([1, 2, 2, 3])
message = np.array(['OK', 'OK', 'Error' 'OK'])
message = np.array(['OK', 'OK', 'Error', 'OK'])

sp = ShipParams(fuel_rate=fuel, power=power, rpm=rpm, speed=speed,
r_wind=rwind, r_calm=rcalm, r_waves=rwaves,
Expand Down