Repository navigation
Add shared Nethernet advertisement schemas - #1325
Closed
extremeheat wants to merge 1 commit into
Closed
extremeheat wants to merge 1 commit into
extremeheat wants to merge 1 commit into
Conversation
This was referenced Sep 22, 2026
Member
Author
|
Closing the schema extraction: the advertisement definitions will remain in bedrock-protocol. extremeheat/minecraft-bedrock-server#37 can use its shared discovery API directly, so this move is unnecessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the Nethernet advertisement ProtoDef definitions from bedrock-protocol into shared Minecraft data. The file contains the v4/v7 layouts and the optional v4 trailer. Discovery layouts are independent of the advertised game version, so this belongs in
data/bedrock/commonand can be decoded before a Minecraft version is known.This is an unchanged extraction of
src/nethernet/advertisement.jsonfrom PrismarineJS/bedrock-protocol. Bedrock will consume it through the minecraft-data npm package, allowing minecraft-bedrock-server to use Bedrock's shared discovery API instead of carrying duplicate schemas and transport code.