Repository navigation
Use bedrock-protocol for RakNet and Nethernet discovery - #37
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 22, 2026
Owner
Author
|
/makerelease |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace #36 with discovery delegated to bedrock-protocol. The server runner selects RakNet or Nethernet from the generated
server.properties, calls Bedrock's sharedping()API, and formats the metadata. Remove the runner's own UDP ping implementation and semicolon parser; there are no local Nethernet schemas or crypto/packet implementations.The result adds
transport, preserves the raw advertisement, and reports Nethernet's advertisement layout version. Empty advertisements cause retries instead of returning empty metadata. The publicparsePongDetailshelper delegates advertisement decoding to Bedrock as well. Discovery can report a Minecraft version that Bedrock cannot yet connect to.Uses the published
bedrock-protocol@^3.60.0, including the shared discovery API from PrismarineJS/bedrock-protocol#822. Advertisement schemas remain in Bedrock; no schema-extraction PRs, Git pins, or extra minecraft-data release are needed.This is a production dependency on Bedrock; Bedrock's reverse dependency on this runner is development-only. Node 24 is now required, and CI is updated accordingly. Nethernet LAN discovery requires LAN visibility and one discoverable local server at a time, documented in the README.
Validation: lint and the API/server tests passed locally against the shared Bedrock checkout, including real RakNet 1.21.80 and Nethernet 1.26.51 metadata queries. The CLI help test passes with its allowance raised from 2 to 10 seconds for the larger dependency tree. Linux and Windows CI passed with the Git dependency; CI is running again against the published npm dependency.