Repository navigation
[AI Improvement] [Task] Remove dead deploy-path helpers: src/deploy/hosting/args.ts, pubsub getTopic/updateTopic, iam.getDefaultCloudBuildServiceAgent, isEndpointFiltered - #11359
Merged
joehan merged 3 commits intoOct 31, 2026
Conversation
…ing/args.ts, pubsub getTopic/updateTopic, iam.getDefaultCloudBuildServiceAgent, isEndpointFiltered (b/577230920)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request cleans up the codebase by removing several unused functions and types across different modules, including isEndpointFiltered in functionsDeployHelper.ts, an unused payload type file, getDefaultCloudBuildServiceAgent in iam.ts, and getTopic and updateTopic in pubsub.ts. There are no review comments, and I have no feedback to provide.
joehan
marked this pull request as ready for review
October 30, 2026 20:07
joehan
enabled auto-merge (squash)
October 31, 2026 00:05
joehan
deleted the
ai-improve-577230920-task-remove-dead-deploy-path-helper
branch
October 31, 2026 00:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves Buganizer b/577230920
Removes 4 dead deploy-path helpers with zero references across the repository (Wave 6 of dead-code cleanup parent goal b/563463614):
src/deploy/hosting/args.ts: Deleted 3-line type-only module unreferenced since addition in firebase-frameworks integration #4391.src/gcp/pubsub.ts: Deleted unusedgetTopic()andupdateTopic()(callers removed in Launch endpoints refactor #3831).src/gcp/iam.ts: Deleted unusedgetDefaultCloudBuildServiceAgent()(duplicate ofcloudbuild.getDefaultServiceAccount()).src/deploy/functions/functionsDeployHelper.ts: Deleted uncalledisEndpointFiltered(). KeptisCodebaseFiltered()for pending caller in fix: honor functions --except for codebases and IAM checks #9505.Scenarios Tested
npm run build: Passed cleanly.npm run lint:quiet: Passed with 0 errors across the repository.npm run test:compile: Clean type check.npx mocha src/deploy/functions/functionsDeployHelper.spec.ts src/gcp/iam.spec.ts src/deploy/functions/release/fabricator.spec.ts: 199 passing tests.git grep -n -w -E "getTopic|updateTopic|getDefaultCloudBuildServiceAgent|isEndpointFiltered" -- .: 0 matches.test ! -e src/deploy/hosting/args.ts: Verified file is removed.Sample Commands
N/A (Internal dead code removal)