Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/deploy/functions/functionsDeployHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -265,11 +265,6 @@ export function isCodebaseFiltered(codebase: string, filters: EndpointFilter[]):
});
}

/** Checks if a function should be filtered given a list of endpoints. */
export function isEndpointFiltered(endpoint: backend.Endpoint, filters: EndpointFilter[]): boolean {
return filters.some((filter) => endpointMatchesFilter(endpoint, filter));
}

/** Checks if a codebase has any intra-codebase (partial) filters targeting specific function IDs. */
export function isCodebasePartiallyFiltered(codebase: string, filters?: EndpointFilter[]): boolean {
if (!filters) {
Expand Down
3 changes: 0 additions & 3 deletions src/deploy/hosting/args.ts

This file was deleted.

5 changes: 0 additions & 5 deletions src/gcp/iam.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,6 @@

const apiClient = new Client({ urlPrefix: iamOrigin(), apiVersion: "v1" });

/** Returns the default cloud build service agent */
export function getDefaultCloudBuildServiceAgent(projectNumber: string): string {
return `${projectNumber}@cloudbuild.gserviceaccount.com`;
}

// IAM Policy
// https://cloud.google.com/resource-manager/reference/rest/Shared.Types/Policy
export interface Binding {
Expand Down Expand Up @@ -254,7 +249,7 @@
}

/** Utility to print the required binding commands */
export function printManualIamConfig(

Check warning on line 252 in src/gcp/iam.ts

View workflow job for this annotation

GitHub Actions / lint (24)

Missing return type on function
requiredBindings: Binding[],
projectId: string,
prefix: string,
Expand Down
13 changes: 0 additions & 13 deletions src/gcp/pubsub.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,25 +30,12 @@
messageRetentionDuration?: proto.Duration;
}

export async function createTopic(topic: Topic): Promise<Topic> {

Check warning on line 33 in src/gcp/pubsub.ts

View workflow job for this annotation

GitHub Actions / lint (24)

Missing JSDoc comment
const result = await client.put<Topic, Topic>(topic.name, topic);
return result.body;
}

export async function getTopic(name: string): Promise<Topic> {
const result = await client.get<Topic>(name);
return result.body;
}

export async function updateTopic(topic: Topic): Promise<Topic> {
const queryParams = {
updateMask: proto.fieldMasks(topic).join(","),
};
const result = await client.patch<Topic, Topic>(topic.name, topic, { queryParams });
return result.body;
}

export async function deleteTopic(name: string): Promise<void> {

Check warning on line 38 in src/gcp/pubsub.ts

View workflow job for this annotation

GitHub Actions / lint (24)

Missing JSDoc comment
await client.delete(name);
}

Expand Down
Loading