Repository navigation
feat: Read apt dependencies from [tool.frappe-cloud] - #616
Merged
regdocs merged 2 commits intoNov 3, 2026
Merged
Conversation
[deploy.dependencies.apt] is not a valid pyproject.toml table, because PEP 518 reserves all top-level tables except [tool.*]. Also read [tool.frappe-cloud] apt-dependencies and keep the legacy key working. Remove duplicate package names.
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
 |
…-cloud-apt-deps # Conflicts: # agent/tests/test_builder.py
Member
|
@Mergifyio backport master |
Contributor
❌ No backport have been createdDetails
This pull request contains a merge commit ( |
Member
|
Mergify couldn't backport this because of the merge commit, so I opened a manual backport to |
regdocs
added a commit
that referenced
this pull request
Nov 3, 2026
backport(master): feat: Read apt dependencies from [tool.frappe-cloud] (#616)
Contributor
Author
|
Thanks! I've merged the docs as well |
This was referenced Nov 3, 2026
regdocs
pushed a commit
to frappe/press
that referenced
this pull request
Nov 4, 2026
The [deploy.dependencies.apt] table is not valid per PEP 518, which reserves all top-level tables except [tool.*]. Strict validators reject it. Read [tool.frappe-cloud] apt-dependencies too, like the builder does since frappe/agent#616. The legacy key still works, and the existing dedup lets an app list a package under both keys while it migrates.
aljifrikhaled
pushed a commit
to aljifrikhaled/press
that referenced
this pull request
Nov 11, 2026
The [deploy.dependencies.apt] table is not valid per PEP 518, which reserves all top-level tables except [tool.*]. Strict validators reject it. Read [tool.frappe-cloud] apt-dependencies too, like the builder does since frappe/agent#616. The legacy key still works, and the existing dedup lets an app list a package under both keys while it migrates. (cherry picked from commit ad07fd2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Apps declare extra apt packages in
pyproject.tomllike this:This table is not valid. PEP 518 reserves all top-level tables except
[tool.*]for future specifications. Strict validators such asvalidate-pyprojectreject the file.Change
The builder now also reads a key in the
[tool.*]namespace:[deploy.dependencies.apt]key still works.Docs: https://docs.frappe.io/wiki-app/spaces/7ncdodb8sb/change-requests/91adai4u3o