Repository navigation
Report the language code when transcribe() is given a language name - #2891
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI accepts language names for
--language(for example--language Japanese), andtranscribe()accepts them too, becauseget_tokenizer()maps names to codes. The tokenizer and decoder then use the code, buttranscribe()returns the original string, soresult["language"]is"Japanese"instead of"ja", and"EN"stays"EN". The JSON output carries the same value. When the language is detected, or given as a lowercase code, the result holds a code, so anything that readsresult["language"]sees two different formats.Changes
transcribe()now lowercases the requested language and maps a name to its code throughTO_LANGUAGE_CODEbefore it builds the tokenizer, and stores that code indecode_options. A name such as"English"or"english"and a code in any case such as"EN"all produce"en". Unsupported values still raise the sameValueErrorfromget_tokenizer().test_language_is_reported_as_a_code, which transcribesjfk.flacwith thetinymodel usinglanguage="English"andlanguage="EN", and checks thatresult["language"] == "en".Reproduce
Before:
English. After:en.Testing
main(assert 'English' == 'en',assert 'EN' == 'en') and passes with this change.pytest -k 'not test_transcribe or test_transcribe[tiny] or test_transcribe[tiny.en]' -m 'not requires_cuda'passes.black,isort, andflake8with the pre-commit settings report no issues.