Skip to content

Report the language code when transcribe() is given a language name #2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RaphaelFakhri wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −1
Open

Report the language code when transcribe() is given a language name #2891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tests/test_transcribe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,13 @@ def test_transcribe(model_name: str):
timing_checked = True

assert timing_checked


@pytest.mark.parametrize("language", ["English", "EN"])
def test_language_is_reported_as_a_code(language: str):
model = whisper.load_model("tiny")
audio_path = os.path.join(os.path.dirname(__file__), "jfk.flac")

result = model.transcribe(audio_path, language=language, temperature=0.0)
assert result["language"] == "en"
assert "my fellow americans" in result["text"].lower()
4 changes: 3 additions & 1 deletion whisper/transcribe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,9 @@ def transcribe(
f"Detected language: {LANGUAGES[decode_options['language']].title()}"
)

language: str = decode_options["language"]
# report a language given by name (e.g. "English") as its code (e.g. "en")
language: str = decode_options["language"].lower()
language = decode_options["language"] = TO_LANGUAGE_CODE.get(language, language)
task: str = decode_options.get("task", "transcribe")
tokenizer = get_tokenizer(
model.is_multilingual,
Expand Down