Repository navigation
orchestration, pis: move the gwas catalog top hits release into a dated prod run folder - #220
Merged
Merged
Conversation
…ed prod run folder The 2026-08-28 top hits run now lives in gs://gwas_catalog_top_hits/prod/20260828T165117/ with its outputs under output/, its DAG config under config/ and its docs under docs/. - gwas_catalog_top_hits.yaml: output_path points at the run's output/ folder - pis/config.yaml: GCCA study index and credible sets read from the run folder - docs: split the top hits docs into gwas_catalog_top_hits/README.md, with the inputs, the gentroutils sync, gentropy links pinned to v3.4.0-rc.3 and the output schemas; regenerate the broken DAG svg - Makefile: upload-gwas-catalog-top-hits-readme uploads only the top hits docs to the run folder Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
8 tasks done
This was referenced Oct 27, 2026
addramir
approved these changes
Oct 28, 2026
3 tasks
Merged
6 tasks done
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 2026-08-28 GWAS Catalog top hits run was moved from the root of
gs://gwas_catalog_top_hitsinto a dated run folder, so the release is preserved, before we run the v4.0.0 gentropy release with updated credible set schema.This will allow us to compare the results and roll back in case of hard issues discovered upon release.
This PR points the repo at the new location:
gwas_catalog_top_hits.yaml:output_pathis nowgs://gwas_catalog_top_hits/prod/20260828T165117/output. It is identical to the config uploaded to the run folder.pis/config.yaml: the GCCA study index and credible sets are copied from the run'soutput/.docs/datasources/gwas_catalog_data/gwas_catalog_top_hits/README.md. The new README:v3.4.0-rc.3, the version in the configupload-gwas-catalog-top-hits-readmeuploads only the top hits docs to the run folder (GWAS_CATALOG_TOP_HITS_RUN), and is part ofupdate-bucket-docs. The GWAS Catalog upload no longer copies the full docs to the top hits bucket.The bucket is already in this state. The data, config and docs were moved and uploaded, and the files in this PR are identical to the uploaded copies.
Notes
output_pathpinned to the run folder, running the old top hits DAG again would overwrite this release. Bump the timestamp before the next run.Test plan
uv run pytest tests/test_dag_validation.py(orchestration): 10 passeduv run pytest tests(pis): 10 passedmake -n upload-gwas-catalog-top-hits-readmeresolves to the run foldergs://gwas_catalog_top_hits/prod/20260828T165117/study_index/*.parquetandcredible_sets/*.parquetglobs inpis/config.yamlmatch files in the run folder🤖 Generated with Claude Code