Repository navigation
[TwigComponent] Fix the flaky render time assertion of the data collector test - #4108
Merged
Kocal merged 1 commit intoOct 15, 2026
Merged
Conversation
…ctor test | Q | A | -------------- | --- | Bug fix? | no | New feature? | no | Deprecations? | no | Documentation? | no | Issues | | License | MIT `TwigComponentDataCollectorTest::testLateCollectWithCollectedData()` expects a positive render time between a `PreRenderEvent` and a `PostRenderEvent` logged back to back. Both events get their time from `microtime(true)`, which often returns the same value for two calls that close. Repeating the sequence of the test 10,000 times gives a render time of `0.0` in 7,472 runs. The test now waits 1 µs between the two events, and the same 10,000 runs never give `0.0`. The failure showed up at random in the TwigComponent suite while working on symfony#4107, in 4 of 6 full runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TwigComponentDataCollectorTest::testLateCollectWithCollectedData()expects a positive render time between aPreRenderEventand aPostRenderEventlogged back to back. Both events get their time frommicrotime(true), which often returns the same value for two calls that close.Repeating the sequence of the test 10,000 times gives a render time of
0.0in 7,472 runs.The test now waits 1 µs between the two events, and the same 10,000 runs never give
0.0. The failure showed up at random in the TwigComponent suite while working on #4107, in 4 of 6 full runs.