Skip to content

[TwigComponent] Fix the flaky render time assertion of the data collector test #4108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kocal merged 1 commit into from
Oct 15, 2026
Merged

[TwigComponent] Fix the flaky render time assertion of the data collector test #4108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/TwigComponent/tests/Unit/DataCollector/TwigComponentDataCollectorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ public function testLateCollectWithCollectedData(bool $collectComponents): void
$mounted = new MountedComponent('foo', new \stdClass(), new ComponentAttributes([], new EscaperRuntime()));
$eventA = new PreRenderEvent($mounted, new ComponentMetadata(['key' => 'foo', 'template' => 'bar']), []);
$logger->onPreRender($eventA);
// without it, both events often get the same microtime() and the render time is 0.0
usleep(1);
$eventB = new PostRenderEvent($mounted);
$logger->onPostRender($eventB);

Expand Down
Loading