Repository navigation
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lahfir
changed the title
lahfir
force-pushed
the
laf/bidi-snapshot-refs-input
branch
from
October 23, 2026 16:40
3da6bf1 to
b211f08
Compare
ctate
reviewed
Oct 23, 2026
lahfir
force-pushed
the
laf/bidi-snapshot-refs-input
branch
from
October 23, 2026 20:45
b211f08 to
caea631
Compare
ctate
reviewed
Oct 23, 2026
lahfir
force-pushed
the
laf/bidi-snapshot-refs-input
branch
from
October 23, 2026 22:52
caea631 to
01d925b
Compare
lahfir
force-pushed
the
laf/bidi-snapshot-refs-input
branch
from
October 23, 2026 23:21
01d925b to
284114f
Compare
lahfir
force-pushed
the
laf/bidi-snapshot-refs-input
branch
from
October 26, 2026 20:33
284114f to
642e9bb
Compare
lahfir
force-pushed
the
laf/bidi-snapshot-refs-input
branch
from
October 26, 2026 22:42
642e9bb to
e63e7be
Compare
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
ctate
approved these changes
Nov 7, 2026
Fold the destroyed-tab handling into the top_context model: a destroyed top-level tab drops its ids, labels, refs and documents, and the session falls back to a surviving tab. The getTree lookup stays as the fallback when no tab is left.
ctate
reviewed
Nov 8, 2026
…text insertion check and uncheck fall back to a JS click on hidden checkboxes. hover, tap and drag skip the actionability check. Back and forward buttons use BiDi button codes 3 and 4. drag commits mouse state. Text insertion with no editable focus succeeds and drops the text.
ctate
approved these changes
Nov 8, 2026
ctate
reviewed
Nov 8, 2026
… fill Frame points are mapped into the page viewport before they are stored, so later commands do not press at a stale coordinate. fill and type report dialogOpened when focusing opens a prompt.
ctate
approved these changes
Nov 8, 2026
ctate
reviewed
Nov 9, 2026
| let (mut tree_nodes, roots) = build_tree(nodes); | ||
| assign_refs( | ||
| &mut tree_nodes, | ||
| &HashMap::new(), |
Collaborator
There was a problem hiding this comment.
Firefox can only call this with an empty cursor map, so cursor:pointer/onclick/tabindex elements never get refs; a clickable
with text can snapshot as "(empty page)". Reproduced.
| .and_then(Value::as_i64) | ||
| .unwrap_or(1) | ||
| .max(0) as u32; | ||
| let actions = pointer_click( |
Collaborator
There was a problem hiding this comment.
click, dblclick and drag never read inputMode or seed, so --human and --input-mode are silently ignored on Firefox even though click/drag are documented to move with a curve. Not reproduced.
ctate
reviewed
Nov 10, 2026
| let (mut tree_nodes, roots) = build_tree(nodes); | ||
| assign_refs( | ||
| &mut tree_nodes, | ||
| &HashMap::new(), |
Collaborator
There was a problem hiding this comment.
Firefox snapshots pass an empty cursor-interactive map, so elements the AX tree exposes without an interactive role (a div with onclick, cursor:pointer, hidden radio labels) get no ref and cannot be targeted by ref. Reproduced.
| } | ||
|
|
||
| /// Clicks a ref or selector, returning Chrome's `{clicked}` shape. | ||
| pub async fn click(cmd: &Value, state: &mut DaemonState) -> Result<Value, String> { |
Collaborator
There was a problem hiding this comment.
click, dblclick and drag never read inputMode or seed, so --human/--input-mode are silently ignored and the pointer jumps to the target in one 0ms move, unlike Chrome. Reproduced.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.