Repository navigation
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lahfir
changed the title
lahfir
force-pushed
the
laf/bidi-network-emulation
branch
from
October 23, 2026 16:40
246e6a3 to
4b124fc
Compare
lahfir
force-pushed
the
laf/bidi-network-emulation
branch
from
October 23, 2026 20:45
4b124fc to
0ccffcc
Compare
lahfir
force-pushed
the
laf/bidi-network-emulation
branch
from
October 23, 2026 22:52
0ccffcc to
b4a4ab3
Compare
lahfir
force-pushed
the
laf/bidi-network-emulation
branch
from
October 23, 2026 23:21
b4a4ab3 to
c52376d
Compare
lahfir
force-pushed
the
laf/bidi-network-emulation
branch
from
October 26, 2026 20:33
c52376d to
c1aa149
Compare
lahfir
force-pushed
the
laf/bidi-network-emulation
branch
from
October 26, 2026 22:42
c1aa149 to
52314a3
Compare
ctate
reviewed
Nov 7, 2026
ctate
approved these changes
Nov 7, 2026
The launch path opened a second RDP connection and enabled accessibility again, left over from a merge. Drop the duplicate block.
Destroyed-tab handling now lives in FirefoxSession::track_tabs, called from drain_events. network::drain resets ref and frame state when the active tab changes.
The 90 second RDP timeout only hid the hang caused by the duplicate DevTools connection, which is fixed. Go back to 30 seconds so a real hang still fails fast.
ctate
reviewed
Nov 8, 2026
ctate
approved these changes
Nov 8, 2026
…jected Update --help and the command references to describe proxy credentials as supported and keep the rejected list accurate.
ctate
approved these changes
Nov 8, 2026
ctate
approved these changes
Nov 8, 2026
ctate
approved these changes
Nov 9, 2026
|
|
||
| - name: Run Firefox e2e tests | ||
| run: cargo test --profile ci --manifest-path cli/Cargo.toml e2e_firefox -- --ignored --test-threads=1 --skip e2e_firefox_route_mock --skip e2e_firefox_allowed_domains --skip e2e_firefox_download --skip e2e_firefox_emulation | ||
| run: cargo test --profile ci --manifest-path cli/Cargo.toml e2e_firefox -- --ignored --test-threads=1 |
Collaborator
There was a problem hiding this comment.
The Firefox suite now runs without skips, but none of these tests cover origin headers, HAR, console/errors, request detail, response body, offline, user-agent, locale, geolocation, or permissions, so regressions in those new handlers still pass CI.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.