Repository navigation
Conversation
lpinca
commented
Oct 8, 2026
| // response before emitting the `'upgrade'` event. See | ||
| // https://github.com/nodejs/node/commit/e5778f78. | ||
| // | ||
| if (process.versions.modules >= 152) return this.skip(); |
Member
Author
There was a problem hiding this comment.
Waiting for the actual value of NODE_MODULE_VERSION for Node.js version 27.0.0-alpha.0.0.0.
There was a problem hiding this comment.
It was 150 when nodejs/node@e5778f78 landed.
Member
Author
There was a problem hiding this comment.
I'm waiting for the first official release, not a nightly, not built on main.
In Node.js versions >= 27.0.0-alpha.0.0.0 the HTTP client rejects the response before emitting the `'upgrade'` event. Refs: nodejs/node@e5778f78
|
modules is $ node -e "console.log(process.versions)"
{
node: '27.0.0-alpha.0.0.0',
acorn: '8.19.0',
ada: '4.0.0',
amaro: '1.1.11',
ares: '1.34.9',
brotli: '1.2.1',
cldr: '48.0',
icu: '78.3',
libffi: '3.8.0',
lief: '1.0.0',
llhttp: '9.4.3',
merve: '1.2.2',
modules: '153',
napi: '10',
nbytes: '0.1.4',
ncrypto: '0.0.1',
nghttp2: '1.70.0',
nghttp3: '',
ngtcp2: '',
openssl: '4.1.0',
simdjson: '5.0.5',
simdutf: '7.7.0',
sqlite: '3.54.1',
tz: '2026e',
undici: '8.12.3',
unicode: '17.0',
uv: '1.52.1',
uvwasi: '0.0.23',
v8: '15.6.75.25-node.10',
zlib: '1.3.2.1-motley-9f9f52c',
zstd: '1.5.7'
}I saw in nodejs/citgm#1190 that you're planning to cut a new release today. That would be great 👍🏻 |
|
If you want to test in GitHub Actions, you can use I submitted a feature request actions/setup-node#1657 earlier today about this. |
Member
Author
|
Noticed, but there is another issue with macOS-latest and the x64 arch in the test matrix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Node.js versions >= 27.0.0-alpha.0.0.0 the HTTP client rejects the response before emitting the
'upgrade'event.Refs: nodejs/node@e5778f78
Refs: nodejs/citgm#1190