Skip to content

Skip test on Node.js versions where it does not apply #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpinca merged 1 commit into from
Oct 30, 2026
Merged

Skip test on Node.js versions where it does not apply #2340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion test/websocket.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -984,7 +984,14 @@ describe('WebSocket', () => {
beforeEach((done) => server.listen(0, done));
afterEach((done) => server.close(done));

it('fails if the Upgrade header field value cannot be read', (done) => {
it('fails if the Upgrade header cannot be read', function (done) {
//
// In Node.js versions >= 27.0.0-alpha.0.0.0 the HTTP client rejects the
// response before emitting the `'upgrade'` event. See
// https://github.com/nodejs/node/commit/e5778f78.
//
if (process.versions.modules >= 153) return this.skip();

server.once('upgrade', (req, socket) => {
socket.on('end', socket.end);
socket.write(
Expand Down
Loading